Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: use DJANGO_SETTINGS_MODULE from env if available #153

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RFC: use DJANGO_SETTINGS_MODULE from env if available #153

wants to merge 1 commit into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Sep 4, 2019

This avoids setting it in setup.cfg explicitly, and follows the usual
pattern of having it defined with Django projects often already.

TODO:

  • doc

@blueyed
RFC: use DJANGO_SETTINGS_MODULE from env if available
94d6831 
This avoids setting it in setup.cfg explicitly, and follows the usual
pattern of having it defined with Django projects often already.

TODO:

- [ ] doc
@blueyed blueyed force-pushed the env-DJANGO_SETTINGS_MODULE branch from 1aeaad9 to 94d6831 Compare September 4, 2019 14:51
@sobolevn
Copy link
Member

sobolevn commented Sep 4, 2019

I like this! @mkurnikov what do you think?

@blueyed blueyed mentioned this pull request Sep 17, 2019
Closed
@blueyed
Copy link
Contributor Author

blueyed commented Sep 17, 2019

(btw: would help also in case where the env is required already anyway (#166 (comment)))

@sobolevn sobolevn requested a review from mkurnikov September 17, 2019 11:28
@mkurnikov
Copy link
Member

@blueyed Maybe add test for it?

@blueyed
Copy link
Contributor Author

blueyed commented Sep 17, 2019

Sure, but likely not in the near future.
Doc needs also to be done.

@mkurnikov mkurnikov added this to the 1.2.0 milestone Sep 24, 2019
@mkurnikov
Copy link
Member

@sobolevn @blueyed I'm going to release 1.2.0 today, this one will get into 1.2.1, when it's done.

@mkurnikov mkurnikov modified the milestones: 1.2.0, 1.2.1 Sep 30, 2019
@sobolevn
Copy link
Member

@mkurnikov I don't think that it is a good candidate for 1.2.1 - because it can break things!

My suggestion is to put it into 1.2.0. Do you need any help from my side?

@mkurnikov mkurnikov removed this from the 1.2.1 milestone Nov 12, 2019
@charettes
Copy link
Contributor

charettes commented Apr 28, 2020 •
edited
Loading

Is this still on some release road map? Maybe only falling back to the environ value if no mypy.plugins.django-stubs.django_settings_module option is defined would do a better job at preserving backward compatiblity since this case currently error out.

@armanckeser armanckeser mentioned this pull request Mar 21, 2024
Merged
voidus pushed a commit to voidus/django-stubs that referenced this pull request Apr 23, 2024
@Javrd
Updates django.contrib.postgres.indexes types (typeddjango#154)
4f6e1c5 
Close typeddjango#153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

@mkurnikov mkurnikov mkurnikov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blueyed @sobolevn @mkurnikov @charettes